Re: [PATCH] libxl: Add "grant_usage" parameter for virtio disk devices

[Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>]

On 02.02.24 13:03, Viresh Kumar wrote:

Hello Viresh


> On 02-02-24, 12:49, Oleksandr Tyshchenko wrote:
>> diff --git a/docs/man/xl-disk-configuration.5.pod.in 
>> b/docs/man/xl-disk-configuration.5.pod.in
>> index bc945cc517..3c035456d5 100644
>> --- a/docs/man/xl-disk-configuration.5.pod.in
>> +++ b/docs/man/xl-disk-configuration.5.pod.in
>> @@ -404,6 +404,31 @@ Virtio frontend driver (virtio-blk) to be used. Please 
>> note, the virtual
>>   device (vdev) is not passed to the guest in that case, but it still must be
>>   specified for the internal purposes.
>>   
>> +=item B<grant_usage=BOOLEAN>
>> +
>> +=over 4
>> +
>> +=item Description
>> +
>> +Specifies the usage of Xen grants for accessing guest memory. Only 
>> applicable
>> +to specification "virtio".
>> +
>> +=item Supported values
>> +
>> +If this option is B<true>, the Xen grants are always enabled.
>> +If this option is B<false>, the Xen grants are always disabled.
>> +
>> +=item Mandatory
>> +
>> +No
>> +
>> +=item Default value
>> +
>> +If this option is missing, then the default grant setting will be used,
>> +i.e. enable grants if backend-domid != 0.
>> +
>> +=back
>> +
>>   =back
>>   
>>   =head1 COLO Parameters
> 
> I wonder if there is a way to avoid the duplication here and use the 
> definition
> from: docs/man/xl.cfg.5.pod.in somehow ?


That's good point. I am not 100% sure, but if we could use something 
like that it would be really nice. Let's see what other reviewers will say.


=item B<grant_usage=BOOLEAN>

=over 4

Specifies the usage of Xen grants for accessing guest memory. Only 
applicable to specification "virtio". Please see B<grant_usage> in 
L<xl.cfg(5)> for more information on this option.

=back