Re: [PATCH v3 17/33] tools/xl: support new 9pfs backend xen-9pfsd

[Juergen Gross <jgross@xxxxxxxx>]

On 02.02.24 16:28, Juergen Gross wrote:
> On 31.01.24 16:20, Jürgen Groß wrote:
> > On 15.01.24 16:14, Anthony PERARD wrote:
> > > On Thu, Jan 04, 2024 at 10:00:39AM +0100, Juergen Gross wrote:
> > > > @@ -2242,6 +2256,28 @@ void parse_config_data(const char *config_source,
> > > >               libxl_string_list_dispose(&pairs);
> > > > +            if (p9->type == LIBXL_P9_TYPE_UNKNOWN) {
> > > > +                p9->type = LIBXL_P9_TYPE_QEMU;
> > > The defaulting is normally done in libxl, so that it works for all users
> > > of libxl. Can this be done instead in libxl? Hopefully, it's enough to
> > > do it in libxl__device_p9_setdefault().
> > >
> > > Same question for the followup checks and default values.
> > I'll look into it.
> Turns out this would need some hack, as I have no access to the name of
> the domain being created in libxl__device_p9_setdefault(). And this is needed
> for setting the path default value.
>
> Do you have any idea how to resolve this issue, or are you fine to keep the
> patch as is?
Just found a hopefully acceptable solution: if the type is XEN_9PFSD and no
path has been specified I set it in xl_parse.c. The rest of the default
settings and consistency checks are done in libxl.

Is this okay for you?


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature