Re: [PATCH] tools/xentop: add option to display dom0 first

[zithro <slack@xxxxxxxxx>]

On 05 Feb 2024 18:27, Anthony PERARD wrote:
> On Wed, Jan 31, 2024 at 06:51:34PM +0100, Cyril Rébert wrote:
> > Add a command line option to xentop to be able to display dom0 first, on top of 
> > the list.
> > This is unconditional, so sorting domains with the S option will also ignore 
> > dom0.
> >
> > Signed-off-by: Cyril Rébert (zithro) <slack@xxxxxxxxx>
> Hi Cyril,
Hi Anthony,

> Your patch looks like a good idea
Thanks, I also have a "display dom id column" in the pipes, almost ready 
to send, but I found kind of a bug doing this (field_id/fields offsets 
off by one).
Are there "most wanted functionnalities" concerning xentop, while I'm at 
it ? There's a TODO in xentop's folder.
Things I'd like to add, if possible, is domain management 
(pause/unpause, maybe shutdown/destroy), columns hiding and domains hiding.
> but xentop segv without '-z' now, when there are guest running.
I failed at the strict minimum here, should have tested ... Sorry for 
wasting your time !
Bug spotted ("sort_start" incorrectly initialized), will post a v2.

> Revelant part of a backtrace:
> #0  xenstat_domain_name (domain=0x121) at xenstat.c:344
> 344             return domain->name;
> #6  0x00006344dd283651 in top () at xentop.c:1209
>          i = 2
>          num_domains = 2
>          sort_start = 1
>          sort_count = <optimized out>
>          dom0_index = <optimized out>
> 1209            qsort((domains+sort_start), (num_domains-sort_count), 
> sizeof(xenstat_domain *),
> 1210                  (int(*)(const void *, const void *))compare_domains);
What soft did you use to get that output ? A debugger ?
(It's a real question, I'm a noob).

> Also, could you update the man page? Here "docs/man/xentop.1.pod""
Will do with v2 !

> Thanks,
--
++
zithro / Cyril