Re: [PATCH] config: update Mini-OS commit

[Jürgen Groß <jgross@xxxxxxxx>]

On 07.02.24 14:41, Julien Grall wrote:
> Hi Juergen,
>
> On 07/02/2024 13:31, Juergen Gross wrote:
> > Update the Mini-OS upstream revision.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > ---
> >   Config.mk | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Config.mk b/Config.mk
> > index f7d6d84847..077d841bb7 100644
> > --- a/Config.mk
> > +++ b/Config.mk
> > @@ -224,7 +224,7 @@ QEMU_UPSTREAM_URL ?= 
> > https://xenbits.xen.org/git-http/qemu-xen.git
> >   QEMU_UPSTREAM_REVISION ?= master
> >   MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git
> > -MINIOS_UPSTREAM_REVISION ?= 090eeeb1631f00a9a41ebf66d9b4aacb97eb51e7
> > +MINIOS_UPSTREAM_REVISION ?= b119f0178fd86876d0678007dfcf435ab8bb7568
> I looked at the changes and I am puzzled by one. In p9_stat(), I see a call 
> with:
>
>    free_stat(&stat);
>
> 'stat' is defined as 'struct p9_stat *stat' and 'free_stat' expects a 'struct 
> p9_stat'.
> Wouldn't this resuilt to a build error?
Hmm, I'm puzzled, too. I didn't see a build error when doing "make testbuild".

But I agree that this looks very suspicious.

Oh, in test builds we don't have HAVE_LIBC defined. I just verified that
9pfront.c gets compiled, while I didn't pay attention to the parts which were
compiled during the build. Shame on me!

Fixup patch coming soon...

Thanks for noticing!


Juergen