Re: [PATCH v8 2/7] automation: introduce fixed randconfig for RISC-V

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2024-02-12 at 09:39 +0100, Michal Orzel wrote:
> Hi Oleksii,
Hi Michal,

> 
> On 09/02/2024 19:00, Oleksii Kurochko wrote:
> > 
> > 
> > This patch introduces the file riscv-fixed-randconfig.yaml,
> > which includes all configurations that should be disabled for
> > randconfig builds.
> > 
> > Suggested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> > The patch were introduced after discussion in a topic:
> >  
> > https://lore.kernel.org/xen-devel/cover.1701966261.git.oleksii.kurochko@xxxxxxxxx
> > /
> >  ---
> > Changes in V8:
> >  - Nothing changed. Only rebase
> > ---
> > Changes in V7:
> >  - Nothing changed. Only rebase
> > ---
> > Changes in V6:
> >  - The patch was introduced in this version of patch series.
> > ---
> >  automation/gitlab-ci/build.yaml                  | 8 ++++----
> >  automation/gitlab-ci/riscv-fixed-randconfig.yaml | 7 +++++++
> >  2 files changed, 11 insertions(+), 4 deletions(-)
> >  create mode 100644 automation/gitlab-ci/riscv-fixed-
> > randconfig.yaml
> > 
> > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-
> > ci/build.yaml
> > index 6d2cb18b88..376eb17f9c 100644
> > --- a/automation/gitlab-ci/build.yaml
> > +++ b/automation/gitlab-ci/build.yaml
> > @@ -512,6 +512,8 @@ alpine-3.18-gcc-debug-arm64-boot-cpupools:
> >        CONFIG_BOOT_TIME_CPUPOOLS=y
> > 
> >  # RISC-V 64 cross-build
> > +include: 'automation/gitlab-ci/riscv-fixed-randconfig.yaml'
> I don't think there is a need to create a new file for that.
> You could define an anchor in build.yaml:
> 
> # RISC-V 64 cross-build
> .riscv-fixed-randconfig:
>   variables: &riscv-fixed-randconfig
>     EXTRA_FIXED_RANDCONFIG: |
>       CONFIG_COVERAGE=n
>       CONFIG_EXPERT=y
>       CONFIG_GRANT_TABLE=n
>       CONFIG_MEM_ACCESS=n
> 
> and reference it in the job:
> 
> archlinux-current-gcc-riscv64-randconfig:
>   extends: .gcc-riscv64-cross-build
>   variables:
>     CONTAINER: archlinux:current-riscv64
>     KBUILD_DEFCONFIG: tiny64_defconfig
>     RANDCONFIG: y
>     <<: *riscv-fixed-randconfig
I've created a new file just for convenience, build.yaml. It is pretty
large, and it's not always easy to navigate, especially when you don't
remember a specific name.
This is not directly related to this patch, but it seems to me that it
would be better to create arch-specific files and include them in
build.yaml.

If it would be better not to create a new file, I am okay to drop it
and add everything to build.yaml.

Thanks.

~ Oleksii