Re: [PATCH 4/4] libxl: Support blktap with HVM device model

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Feb 01, 2024 at 01:30:24PM -0500, Jason Andryuk wrote:
> diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c
> @@ -1337,10 +1338,18 @@ char *libxl__device_disk_find_local_path(libxl__gc 
> *gc,
>          LOGD(DEBUG, guest_domid, "Attempting to read node %s", pdpath);
>          path = libxl__xs_read(gc, XBT_NULL, pdpath);
>  
> -        if (path)
> +        if (path) {
>              LOGD(DEBUG, guest_domid, "Accessing cooked block device %s", 
> path);
> -        else
> -            LOGD(DEBUG, guest_domid, "No physical-device-path, can't access 
> locally.");
> +
> +            /* tapdisk exposes disks locally over UNIX socket NBD. */
> +            if (disk->backend == LIBXL_DISK_BACKEND_TAP) {
> +                path = libxl__sprintf(gc, "nbd+unix:///?socket=%s", path);
> +                LOGD(DEBUG, guest_domid,
> +                     "Directly accessing local TAP target %s", path);
> +            }
> +        } else
> +            LOGD(DEBUG, guest_domid,
> +                "No physical-device-path, can't access locally.");

Here, the coding style call to have both side of the if..else to have { }
or none of them. Could you add {}-block for the else side?


Beside that, patch looks fine to me:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD