Re: [PATCH v4 28/30] xen/rirscv: add minimal amount of stubs to build full Xen

[Jan Beulich <jbeulich@xxxxxxxx>]

On 05.02.2024 16:32, Oleksii Kurochko wrote:
> --- a/xen/arch/riscv/early_printk.c
> +++ b/xen/arch/riscv/early_printk.c
> @@ -207,4 +207,3 @@ void printk(const char *format, ...)
>  }
>  
>  #endif
> -

Unrelated change?

> --- a/xen/arch/riscv/traps.c
> +++ b/xen/arch/riscv/traps.c
> @@ -4,6 +4,10 @@
>   *
>   * RISC-V Trap handlers
>   */
> +
> +#include <xen/lib.h>
> +#include <xen/sched.h>
> +
>  #include <asm/processor.h>
>  #include <asm/traps.h>
>  
> @@ -11,3 +15,24 @@ void do_trap(struct cpu_user_regs *cpu_regs)
>  {
>      die();
>  }
> +
> +void vcpu_show_execution_state(struct vcpu *v)
> +{
> +    assert_failed("need to be implented");
> +}
> +
> +void show_execution_state(const struct cpu_user_regs *regs)
> +{
> +    printk("implement show_execution_state(regs)\n");
> +}
> +
> +void arch_hypercall_tasklet_result(struct vcpu *v, long res)
> +{
> +    assert_failed("need to be implented");
> +}
> +
> +enum mc_disposition arch_do_multicall_call(struct mc_state *state)
> +{
> +    assert_failed("need to be implented");
> +    return mc_continue;
> +}

The assert_failed() here want switching to the "canonical" BUG_ON().

Jan