[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB
- To: Petr Beneš <w1benny@xxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 13 Feb 2024 15:36:16 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wMDqOAOqUlR6SMcP0KYloozBSpPOQU4mqbd8n5tfTiE=; b=afl9eFcYAaAxjGWCX7Az2SQXaQ4I6lDcGJVXUV8VcmBYyoFn9eC6XqciZ2xqNPY22eC/MrrQc3qWI6t5eJhAsF9KOa+/ADnCWU/jjMj5iVMiiGv+6BeB2XTFr9W9aY4anJauXqp95UZWAZdDn02icNcwngi1uUgqIZO9FHRyJZP0g7uCLOuGua2oyeTIqoCAh30MNfykuIaqdsrFMyaCOfH1Cmh3SUrbACsgQjZ6HXc/IvLKvrKlUO/Zp0o8abllO9AD49cF+vOlIvGRRDe5iEW0YPNSQY6fobPTjy0uGxSr4z3ElAp1ZWpBs6HtYiHX8J9P+NGrS6kmw05FeklNeA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wMDqOAOqUlR6SMcP0KYloozBSpPOQU4mqbd8n5tfTiE=; b=myjdHFmIlbJ+RNGWUHkwID5ByeRM/RD/zYm2sTNlZPsPwfg+lfAaETCmPQGXaEuk9PBIjZBnD0hmyeD7GEct3lZdO1n7Gk34pXaK/yD97Ts+JBwlu8oHnHxKe6VV7AwfJr9jQqGenHqFK7NAjP1ZJIpmrlFDtZi3m5UXEIvRLUpnmTZts7Qw++403E+XXzNVZoDXzAgT/ZjHecKxUzrHsGV7H/Y4dtbUN0omYGPxTirBUkt5nmVfedFnuC1K8XOoUoAymNJ/v700WUPEAAmNAFBqdMma1xgZyQqETiP3lgg77LoQRMTi6Gk95B/5Yj/r+7pQIpgIRmtiBTcjOQ1KtQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=l32j02c7yzlBQMcBPHy2Re3d53WDECK3MF4qZ/m1vb5CDwkfNuhwOsn6dEeM7vhNUWBl+1anSpSQTBPkxWOTD/yiFhp4i5irykJAvnjh2mXyHqpS55lgC7YTNnSVI2S5R5wDTlHolZ8EdQxB0KHqxfCAqJE669rrf1NW10W3SEqbzqjcggg3xCv7kDYApE8AkobsF+8IrWM7qjtrP0mmM18V3WRoueDgdSxt+RmbnHzoW2yzuPPzkaNSWr3007fHVLSx5y24xWuwa9k51N9u1J0IfAUEAwkkqxger3MFuKLOIv6mZV+TL2BAx0L5kaquHXWMJgAeO/Keu8+Bd0T7rQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHDE1E43bva9Wq4iUYDFZ3JMidMcYw0kTxRCAKpD6zyXtdqEKDQhMHPJUO3kwH8Qju2xr6/66m3rjLsUJi8C6GFOcOGm6IW6tWN226k88TrEyuE3GLMkcYRtpMMFYHz7m0rBNrgFbf3PnZe0PEVgLzrFdnMUSB5jb9H2AzR3nQS2X/kkoUYrLJoMja3rfPDrsXOwHWecMdFRHXgL6mS1WdDcy/EnK7tjBnxEQojG0hnXmGWiOv87EHNwAgIp2gEC1ETG/N48vySvwvbLJmpLiFDjRNrI2W5zHd8JsVDlBYlUjBSh723Ju/xNuk6ck5VpgDicXN4L5VGXA/TiKhO5IA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- Delivery-date: Tue, 13 Feb 2024 15:36:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaXo2+7VlqRIHhmU23d/RZTQZ3VLEIYAUAgAAFEwCAAAKDgA==
- Thread-topic: [PATCH v2] libxl: Fix comment for LIBXL_HAVE_VMTRACE_BUF_KB
> On 13 Feb 2024, at 15:27, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 13.02.2024 16:08, Petr Beneš wrote:
>>> On Tue, Feb 13, 2024 at 4:02 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> On 13.02.2024 15:56, Petr Beneš wrote:
>>>> From: Petr Beneš <w1benny@xxxxxxxxx>
>>>>
>>>> It's located in libxl_domain_build_info, not libxl_domain_create_info.
>>>>
>>>> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>
>>>> Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>>
>>> Any reason you didn't also add the Fixes: tag that Anthony suggested
>>> to put there (for me to recognize that this may need backporting;
>>> didn't check yet when that earlier commit went in)?
>>
>> Apologies. No other reason that it's my first experience with creating
>> v2 patch and I honestly didn't know that the "Fixes: tag" suggestion
>> was directed at me. How should I proceed from here?
Hi Petr,
In this case Jan will try to take care of that, if you are interested on how to
do that,
the section ‘1.2 The commit message’ of
https://xenbits.xen.org/docs/unstable/process/sending-patches.html
will explain how to setup git to have the correct configuration for the fixes
tag, afterwards you can just:
1) take the SHA of the commit who introduced the issue:
git blame -L<line num from>,<line num to> -- <path to the file>
2) Get the Fixes tag to be put in the commit message:
git show --pretty=fixes <SHA>
You will see as first line something along the line: “Fixes: 6e9ccda5e475
(“bla bla bla bla bla bla")"
There could be better git command to obtain the same thing, but I always use
the above.
Cheers,
Luca
|
