[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 1/3] xen: introduce Kconfig function alignment option


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 14 Feb 2024 09:20:22 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IxyRVjkHNGh7/pGUHjKlkb4va6U54AzjGMRoKXWMtj8=; b=ONTmn4J3fukbNwdjCmxyfHZBktC/rmTznKaHey6rUn3pkNag0622+5Q7VR4C35uizKWTzvjV1O4BstvXGJF8UEcKqO2w0NnovbOXgQyyxvuU/pcIEfeuWYglcwp/7RT1GwY85YzzDyByHmkm7sG2QvyjlIKpwuF3mnph50R4H0udUPo8tZ9Dzv1REu0fLQM/0vfci9Zap+FhCFS8HrmlW/INZnsmAmQyl4AZMgnjerq/yT0EN/wvBorwGInvQQ2s/O4DZXU6Gt3yP/UgYNaMYvFg/2MDM2xWDeYJ83dvXlupgWp48P39N0KAS906FdZaTU3DDdcyuaDk28VxCw/w8g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9fzC9shUIwRFu4dwtkY5S/bFQIK6B6BGBcw5lECcKj08plEcchBlWysUgcfutGssmkDuXgHesV2XmakHdl8HIrVkOKQiYFM+fWro5LJ77SOK/9+s/O4e63dh3UcS32gjq348oz4EXmOeQnTQNUtWTVb185hBZJg7pc4mdlsQ6EDX6oRxmNCFRbYMzsrkMPNogO3ql//uc81bY3gfXtiWMwhYANk9QFZk1WoZ3izxH9BqDrTCLlb5yRSWtsspBNdV9jI5SXeWSpr+PfdqiDRDlpVL10S96HROiS15ciBJN1/DmUdRss43mXxb4bgBkCVROj0FDW0qoNJGpjaK+E1qg==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, "Connor Davis" <connojdavis@xxxxxxxxx>
  • Delivery-date: Wed, 14 Feb 2024 08:20:39 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 07/02/2024 15:55, Roger Pau Monne wrote:
> 
> 
> And use it to replace CODE_ALIGN in assembly.  This allows to generalize the
> way the code alignment gets set across all architectures.
> 
> No functional change intended.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
In xen/linkage.h, there is still a comment at the top mentioning that 
CODE_ALIGN needs to
be specified by each arch. I think this wants to be removed now. With that and 
Jan's remark
addressed, for Arm:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.