[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] automation/eclair_analysis: deviate certain macros for Rule 20.12
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Wed, 14 Feb 2024 17:10:07 +0100
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, bertrand.marquis@xxxxxxx, julien@xxxxxxx, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Doug Goldstein <cardoe@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Feb 2024 16:10:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024-02-14 16:45, Jan Beulich wrote:
On 14.02.2024 16:31, Nicola Vetrini wrote:
On 2024-02-14 12:49, Jan Beulich wrote:
On 14.02.2024 12:26, Nicola Vetrini wrote:
+-config=MC3R1.R20.12,macros+={deliberate,
"name(ASSERT||BUILD_BUG_ON||BUILD_BUG_ON_ZERO||GENERATE_CASE)"}
I said in another context already that it is necessary to separate
global scope macros from local helper ones. Any CU can introduce
another
GENERATE_CASE(), and would be deviated here right away. In fact I
question applicability of the deviation to arm/arm64/vsysreg.c; I
only
see it as applicable to arm/vcpreg.c.
Why wouldn't this be applicable for vsysreg.c? I can certainly
fine-tune
the deviation, if needed
There the sole macro parameter is used in only one of the possible
ways,
with ##, unless I'm overlooking something. Aiui it is mixed use which
would need a deviation.
I see. In that case I'll restrict the deviation, thanks.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
|
