Re: [PATCH 0/3] xen-analysis.py: Enable Xen deviation tag at the end of the line

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Wed, 31 Jan 2024, Luca Fancellu wrote:
> This serie is enabling the xen-analysis tool to parse and substitute correctly
> a deviation tag put at the end of the line containing a deviation to be 
> deviated.
> 
> Before this serie the only way to deviate a violation was to put the tag in 
> the
> line above:
> 
> /* SAF-<id>-safe deviate the bla bla bla */
> <line containing the violation>
> 
> But there are places in the code base where using the tag in the line above is
> not convinient, for example:
> 
> if ( (expression) &&
>      ((expression with violation) ||
>      (expression) )
> {
>   [...]
> }
> 
> In the above example is better to have the suppression comment at the end of 
> the
> line:
> 
> if ( (expression) &&
>      ((expression with violation) || /* SAF-<id>-safe deviate the bla bla bla 
> */
>      (expression) )
> {
>   [...]
> }
> 
> This clearly brings up the question about the code style line length, which in
> this case needs to be amended for Xen deviation tags that goes above the 
> limit.


Hi Luca,

I tested the series in a number of configurations and everything works
as expected. Great!

For the whole series:

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>