Re: [PATCH] build/xen: fail to rebuild if Kconfig fails

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Thu, Feb 15, 2024 at 10:32:57AM +0000, Anthony PERARD wrote:
> On Thu, Feb 15, 2024 at 10:30:02AM +0100, Roger Pau Monne wrote:
> > When doing a rebuild with an xen/include/config/auto.conf already present in
> > the tree, failures from Kconfig are ignored since the target is present:
> > 
> > gmake -C xen install
> > gmake[1]: Entering directory '/root/src/xen/xen'
> > tools/kconfig/conf  --syncconfig Kconfig
> > common/Kconfig:2: syntax error
> > common/Kconfig:1: invalid statement
> > gmake[2]: *** [tools/kconfig/Makefile:73: syncconfig] Error 1
> >   UPD     include/xen/compile.h
> >  Xen 4.19-unstable
> > gmake[3]: Nothing to be done for 'all'.
> > gmake[2]: 'arch/x86/include/asm/asm-offsets.h' is up to date.
> > 
> > Ultimately leading to a successful build despite the Kconfig error.
> > 
> > Fix this by first removing xen/include/config/auto.conf before attempting to
> > regenerate, and then also make xen/include/config/auto.conf a hard 
> > dependency
> > of the build process (ie: drop the leading '-') and reordering so the .cmd
> > target is executed before including the configuration file.
> 
> Could you try to revert commit 8d4c17a90b0a ("xen/build: silence make
> warnings about missing auto.conf*") instead? With a much shorter message
> like "Don't ignore Kconfig error anymore".

Yes that seems to solve it also.  I guess the point is that for the
target failure to stop execution the include that triggered it needs
to be non-optional (so not - prefixed).

I'm unsure about the consequences of reverting 8d4c17a90b0a, so would
prefer if you could take care of that.

Thanks, Roger.