[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 07/30] xen/asm-generic: introdure nospec.h



Hi Oleksii,

Title: Typo s/introdure/introduce/

On 05/02/2024 15:32, Oleksii Kurochko wrote:
The <asm/nospec.h> header is similar between Arm, PPC, and RISC-V,
so it has been moved to asm-generic.

I am not 100% convinced that moving this header to asm-generic is a good idea. At least for Arm, those helpers ought to be non-empty, what about RISC-V?

If the answer is they should be non-empty. Then I would consider to keep the duplication to make clear that each architecture should take their own decision in term of security.

The alternative, is to have a generic implementation that is safe by default (if that's even possible).

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.