Re: [PATCH v9 7/7] xen/asm-generic: fold struct devarch into struct dev

[Julien Grall <julien@xxxxxxx>]

Hi,

On 16/02/2024 12:39, Oleksii Kurochko wrote:
> The current patch is a follow-up to the patch titled:
>      xen/asm-generic: introduce generic device.h
> Also, a prerequisite for this patch is, without which a compilation
> error will occur:
>      xen/arm: switch Arm to use asm-generic/device.h
>
> The 'struct dev_archdata' is exclusively used within 'struct device',
> so it could be merged into 'struct device.'
>
> After the merger, it is necessary to update the 'dev_archdata()'
> macros and the comments above 'struct arm_smmu_xen_device' in
> drivers/passthrough/arm/smmu.c.
> Additionally, it is required to update instances of
> "dev->archdata->iommu" to "dev->iommu".
>
> Suggested-by: Julien Grall <julien@xxxxxxx>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> ---
>    This patch can be merged with patches 4 and 5 of this patch series.
I am a bit puzzled with this comment. If this is the case, then why was 
it done in a separate patch?
I know I suggested to create the separate patch but this was only in the 
case you decided to handle it after this series is merged. So this 
should have been merged when sending. Maybe I should have been clearer.
Anyway, regardless that:

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall