[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX

To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 20 Feb 2024 16:50:41 +0100
Cc: Christoph Hellwig <hch@xxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
Delivery-date: Tue, 20 Feb 2024 15:50:51 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Feb 20, 2024 at 12:39:59PM +0100, Roger Pau Monné wrote:
> On Tue, Feb 20, 2024 at 09:49:32AM +0100, Christoph Hellwig wrote:
> > Currently xen-blkfront set the max discard limit to the capacity of
> > the device, which is suboptimal when the capacity changes.  Just set
> > it to UINT_MAX, which has the same effect except and is simpler.
> 
> Extra 'except' in the line above?

Yes, thanks.

References:
- convert xen-blkfront to atomic queue limit updates
  - From: Christoph Hellwig
- [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX
  - From: Christoph Hellwig
- Re: [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX
  - From: Roger Pau Monné

Prev by Date: Re: [PATCH] xen: move BUG_ON(), WARN_ON(), ASSERT(), ASSERT_UNREACHABLE() to xen/bug.h
Next by Date: Re: [PATCH 4/4] xen-blkfront: atomically update queue limits
Previous by thread: Re: [PATCH 1/4] xen-blkfront: set max_discard/secure erase limits to UINT_MAX
Next by thread: [PATCH 2/4] xen-blkfront: rely on the default discard granularity
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.