[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/arm: Set correct per-cpu cpu_core_mask
- To: "Orzel, Michal" <Michal.Orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Wang, Henry" <Xin.Wang2@xxxxxxx>
- Date: Mon, 26 Feb 2024 09:54:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WY+M8Q39ASiwK9mzUUf8Hg0KQYd25uiWciIka+VsBCA=; b=a05YZhMUKLwJJ1QD53zFjWWP1rN6dUw2gmg48cRElOv4i/T8a1kVH2dmn0TtHKIS57Sx+xMEMjloo70bTtv0L5L4nG72cs2/vaU07qUyWbCRVLKZ6E0C5vnVMWKdIT3p5FDf66k7/v77VO/lftFZBJlBuK4EozcXmb4gMfytIGxL/4mNyd9DjPj7s1KmqZx/WGSU8wjte6ZoSGiOpps9w3DhpNIqOTacgZxEjWthDm3/0KJhJcdSqGUQB2bt+O9UMMX3Pm+kOuCONhCjUeAM12L+j/Z+kWcECv6zOFmt92pSK7WrVfwxjiNavGC8ku7yj2/fQHf6VfMsEQI20RHz4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hZbInYWXd8GZELS2afBvr4sj04D4spKNoCsBw1YA8v3PqbSk/xZs/htxFD9kelijIEHcKsMxKX8ArTUM3KiCmFuxbw6Lq1Gy5V0aU4ROGbL13shYaF/D3wq8m5UZhpTdNV8Gr9M/yCaFWsJ1QkHVz2+VM7IIiKAEjvpqVY7MC0IYezAmb5g8reGCzwyBGhKpKEWzrqil5CTI3VaNA87kV3EBcVI6Prd+ljgCYGBmTTtT8PjOozR9RCmqoW110BmicigTwtZfI65SbEx1u0xou+O2zNCpNTZ6YAh19DDrVyC/ANZT4Y/di9n21OWNUIk1ErP/8D/FCZE4KWT/O3TQoA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 26 Feb 2024 09:54:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b0971ed1-3c37-4d11-9197-15f40cb44849;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2024-02-26T09:46:39Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
- Thread-index: AQHaaGAnRoGRN1vAm06vXBNQgKmm5rEcXbUAgAAC7lA=
- Thread-topic: [PATCH] xen/arm: Set correct per-cpu cpu_core_mask
[AMD Official Use Only - General]
Hi Michal,
> -----Original Message-----
> Subject: Re: [PATCH] xen/arm: Set correct per-cpu cpu_core_mask
>
> Hi Henry,
>
> On 26/02/2024 04:01, Henry Wang wrote:
> > Signed-off-by: Henry Wang <xin.wang2@xxxxxxx>
> NIT: You first sent this patch as part of NUMA series:
> https://lore.kernel.org/xen-devel/20231120025431.14845-16-
> Henry.Wang@xxxxxxx/
> Shouldn't you retain the Arm's authorship?
Ah good point, in fact I don't really know, since I basically rewrote
the patch I thought it is not really needed. I will add it back in v2 since
you mentioned this.
> > ---
> > xen/arch/arm/smpboot.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > + /* PE not implemented using a multithreading type approach. */
> > + if ( system_cpuinfo.mpidr.mt == 0 )
> Do we need this check? It mt was true, cpu_sibling_mask would be incorrect
> anyway (it would still be 1).
I added this check for playing safe, because I only want to do the correct thing
in this patch and avoid make things worse for MT case. With this patch, non-MT
case can be improved and the MT case is remain unchanged.
But I agree with you, and I would be more than happy if I can run a MT setup and
finish the "else" part with this patch or follow-ups. Do you know maybe qemu can
allow me to emulate a MT setup so that I can fix it properly in v2? Thanks!
Kind regards,
Henry
>
> ~Michal
|
