[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Fix arm32 build failure when early printk is enabled
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 28 Feb 2024 13:42:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1IXjfxMjHnGO9oplCFMYfK64TTR/fPk9KjMyeZlPPk=; b=JaJfTA+DhItzQP/lqXBF3zkND4JbpBnbweervfYiY+ufxmNffOpRy2ISIT6ip2ELCmgK+kHimAF6UkT+Cw52fy1hvgoXjGWDIMS7zVqk9yYOwhi0ueZWfh6NCdQQ6gzudxBbBA9szEWWlMLH7h/DUfTNmsC4T58lAdgXwYu4wd+7L02v9LcJZdAlDYzK1ljy9oYgVtWYa2568tj55c4tgHV6ieHNQBehytlQMb8DNRLG+OJLFUsDl1CO4WStvcVQ2O3fMzZ9TRsZ92xerJfaJ0+u+lDltShxn39HW2JLQPv7y9UpWs9lx/sKoJB6i1SpF9EHWQvh/nFoEpF7EXjzYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jZfL+M8sdAzOUxjx8DxbA2DPaxfI2rj/m6leLZmOt9RD6DQJ/esSVbmzt7208b31M3B++xZYogVuTDNn9krVMprv9pVEw7Jswz+0Z7Hb3ySAwJQ+viBf+aUFTVs1xB/hC3VP7aGZ9/xG8DGFanIFU3Dqk4z/axjuZw8s+L9I8eRjzeQjCEIrgeMMQMe0BjA6LEP572HS5ZkOjl4ARnXrQ3X1LZARjDOMrmVKgQ37UI2/FsmcLS3CIW8SeTehxMVvKvqwNrTzcbbDh7iO1ReHSOU2cwy7RSgY6CzcFd19UvECLI6EEyH4aaA2aWUppZegqdyLBARPwb9GEKTFoGNZ9w==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 28 Feb 2024 12:43:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 28/02/2024 12:42, Julien Grall wrote:
>
>
> Hi Michal,
>
> On 28/02/2024 10:35, Michal Orzel wrote:
>> Commit 0441c3acc7e9 forgot to rename FIXMAP_CONSOLE to FIX_CONSOLE in
>> TEMPORARY_EARLY_UART_VIRTUAL_ADDRESS macro. This results in a build
>> failure on arm32, when early printk is enabled:
>> arch/arm/arm32/mmu/head.S:311: Error: invalid operands (*UND* and *ABS*
>> sections) for `*'
>
> Good catch! Somewhat related I wonder whether we should add earlyprintk
> testing in gitlab?
I thought about adding this and I think we should at least have build jobs
(hypervisor only, no toolstack)
selecting early printk. When it comes to testing if early printk works, I'm not
sure. It'd be nice
but FWIR we have limited bandwidth.
@Stefano, what's your opinion?
~Michal
|
