[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH 09/10] xen/include: tasklet: address violations of MISRA C Rule 20.7
On Thu, 29 Feb 2024, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be safe with respect to expansions that > can possibly alter the semantics of the passed-in macro parameter. > > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> > --- > xen/include/xen/tasklet.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/tasklet.h b/xen/include/xen/tasklet.h > index 593d6a2400fb..78760b694a39 100644 > --- a/xen/include/xen/tasklet.h > +++ b/xen/include/xen/tasklet.h > @@ -27,7 +27,7 @@ struct tasklet > > #define _DECLARE_TASKLET(name, func, data, softirq) \ > struct tasklet name = { \ > - LIST_HEAD_INIT(name.list), -1, softirq, 0, 0, func, data } > + LIST_HEAD_INIT((name).list), -1, softirq, 0, 0, func, data } > #define DECLARE_TASKLET(name, func, data) \ > _DECLARE_TASKLET(name, func, data, 0) > #define DECLARE_SOFTIRQ_TASKLET(name, func, data) \ In reality this is not required due to "struct tasklet name", but for uniformity: Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |