[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BUG]i2c_hid_acpi broken with 4.17.2 on Framework Laptop 13 AMD


  • To: Sébastien Chaumat <euidzero@xxxxxxxxx>
  • From: Mario Limonciello <mario.limonciello@xxxxxxx>
  • Date: Wed, 6 Mar 2024 12:51:28 -0600
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njBIOzkPXzMFuv63yYQen7tK22va6bbzgMd3rSifM58=; b=kQxWnok/YXbUtLREMMbKbsErJt+U9QTQk6r57e4QAfyIJdZAL+t4SrX0/Tn4yhcPRFoc+hvRJPa+ed3y4XMNTb6mJ0Js+ijH1lRCCOHIO2DsgH+Dh7sXqvUskU6HNF5SwskV0WYSjhb7n1HlQS19CfpcTupOwnj4k9+AWnnpqtUOEY4NYFEPabCx/4YvmxTrQZMR5/r8lbNt0bkaTJrhSTyzuacNcQlv3absakr13EluhQC/JJSQp+qL5ofMwtuvEsei4YxNQPkIJBkQ54VKaZ83TGzJ2FTpdiONaorNbvPPQfKlUaXB0AbRYcGWKMPMdtnGrGsyb76NyolsZO/XmQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D+y7TdmXNxBluEQEIVpgetIXXewbJNh+/VaSrdg2F6mhOGzvkvmXTiAuhOXl0eJlFFlWNwW50ZZ7QL/Il3WvNZi2/nMqcgo7lj5tU+zgNp0sPLYFoqz+VjSEZdsyXh7ZnYLv8XlbUeNtIDp4hU5Uh0pf4l1WeNBULqy3mWLuwFPeZPQ9SpSeVj3AbxQHGWj7uzioF2C3n3KC2Qo/GSb0squdHDURfsoYpqtzR46kvvZC0AJmAyv2a6thT3Cyd3oXdNuZNlTbimA2VOAoJ16nseojLYS7Jz7WCfiClCoSkthR01DM2gFdFk02HyHcHDIUxRl+4lcGOP7vrtZVCU2vkA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 06 Mar 2024 18:51:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 3/6/2024 12:49, Sébastien Chaumat wrote:


Le mer. 6 mars 2024 à 19:08, Mario Limonciello <mario.limonciello@xxxxxxx <mailto:mario.limonciello@xxxxxxx>> a écrit :

    On 3/6/2024 12:05, Sébastien Chaumat wrote:
     >
     >
     > Le mer. 6 mars 2024 à 18:33, Mario Limonciello
     > <mario.limonciello@xxxxxxx <mailto:mario.limonciello@xxxxxxx>
    <mailto:mario.limonciello@xxxxxxx
    <mailto:mario.limonciello@xxxxxxx>>> a écrit :
     >
     >     On 3/6/2024 11:28, Sébastien Chaumat wrote:
     >      >
     >      >
     >      >
     >      >
     >      >     Reasoning backward  (using a  kernel without the
    pinctrl_amd
     >     driver
     >      >     to ensure xen only is at stake) :
     >      >       checking the diff in IOAPIC  between bare metal and xen
     >     (IRQ7 is
     >      >     on pin07 on APIC )
     >      >
     >      >     using kernel argument : apic=debug
     >      >
     >      >     bare metal :
     >      >     [    0.715330] fedora kernel: ... APIC VERSION: 81050010
     >      >     ...
     >      >     [    0.715433] fedora kernel:  pin07, disabled, edge ,
    high,
     >     V(00),
     >      >     IRR(0), S(0), physical, D(0000), M(0)
     >      >
     >      >     xen :
     >      >     [    2.249582] fedora kernel: ... APIC VERSION: 00000014
     >      >     ...
     >      >     [    2.249730] fedora kernel:  pin07, disabled, level,
    low ,
     >     V(60),
     >      >     IRR(0), S(0), physical, D(0000), M(0)
     >      >
     >      >     So the APIC table is not the same.
     >      >
     >      >     As strange as it looks the  (IOAPIC 0) pin07 is correctly
     >     described
     >      >     by the APIC in xen but yet differently than in baremetal.
     >      >     But the APIC message comes long after the
     >      >     [    1.833145] fedora kernel: xen: registering gsi 7
    triggering 0
     >      >     polarity 1
     >      >
     >      >     so I wonder if the APIC pin07 info had any influence.
     >      >
     >      > Finally found the fix : adding ioapic_ack=new to xen boot
    parameters.
     >      > Not only the trackpad is now working but also the ACPI
    Embedded
     >      > Controller which is completely disabled.
     >      >
     >      > Sébastien
     >      >
     >     That's great news!  I'm personally totally unfamiliar with
     >     ioapic_ack=new, so I did a quick search and found out it's a Xen
     >     parameter (I came across
     >
    https://xenbits.xen.org/docs/4.5-testing/misc/xen-command-line.html
    <https://xenbits.xen.org/docs/4.5-testing/misc/xen-command-line.html>
>  <https://xenbits.xen.org/docs/4.5-testing/misc/xen-command-line.html <https://xenbits.xen.org/docs/4.5-testing/misc/xen-command-line.html>>).
     >
     >     This mentions that "new" should be the default, so why isn't
    it the
     >     case?
     >
     >
     >   "This is the the default unless directed-EOI is supported"
     > xl dmesg without forcing the parameters shows :
     >
     > (XEN) Enabled directed EOI with ioapic_ack_old on!

    Got it; it sounds to me like a logic mismatch in Xen then.

     >
     >     Also; I'd be really interested to hear what happens with
    s2idle with
     >     Xen
     >     now (if it works).
     >
     >
     > suspend to RAM now works :)

    Do you see /sys/power/suspend_stats/last_hw_sleep increasing with your
    suspend cycle?


No,  it does not increase (0).


OK, then in that case I suggest you run https://gitlab.freedesktop.org/drm/amd/-/blob/master/scripts/amd_s2idle.py in the hypervisor to find out what's wrong.




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.