[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH-for-9.0 6/9] hw/xen/hvm: Initialize xen_physmap QLIST in xen_read_physmap()
- To: qemu-devel@xxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- From: Manos Pitsidianakis <manos.pitsidianakis@xxxxxxxxxx>
- Date: Thu, 07 Mar 2024 13:58:43 +0200
- Bcc:
- Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, David Woodhouse <dwmw@xxxxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, qemu-arm@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Alex Benné e <alex.bennee@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Marcel Apfelbaum <marcel.apfelbaum@xxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Eduardo Habkost <eduardo@xxxxxxxxxxx>
- Delivery-date: Thu, 07 Mar 2024 12:00:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, 14 Nov 2023 18:31, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx> wrote:
xen_read_physmap() is the first function requiring
xen_physmap QLIST being initialized. Move the init
call there.
Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
---
hw/i386/xen/xen-hvm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
index 789779d02c..3b9c31c1c8 100644
--- a/hw/i386/xen/xen-hvm.c
+++ b/hw/i386/xen/xen-hvm.c
@@ -532,6 +532,8 @@ void xen_read_physmap(XenIOState *state)
char path[80], *value = NULL;
char **entries = NULL;
+ QLIST_INIT(&xen_physmap);
+
snprintf(path, sizeof(path),
"/local/domain/0/device-model/%d/physmap", xen_domid);
entries = xs_directory(state->xenstore, 0, path, &num);
@@ -575,6 +577,7 @@ void xen_read_physmap(XenIOState *state)
#else
void xen_read_physmap(XenIOState *state)
{
+ QLIST_INIT(&xen_physmap);
}
#endif
@@ -595,7 +598,6 @@ void xen_hvm_init_pc(PCMachineState *pcms, MemoryRegion
**ram_memory)
xen_register_ioreq(state, max_cpus, &xen_memory_listener);
- QLIST_INIT(&xen_physmap);
xen_read_physmap(state);
suspend.notify = xen_suspend_notifier;
--
2.41.0
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@xxxxxxxxxx>
|
