Re: [PATCH] docs/man: add shutdown reasons to xl (list) man page

[zithro <slack@xxxxxxxxx>]

On 06 Mar 2024 16:43, Anthony PERARD wrote:
> On Tue, Mar 05, 2024 at 11:45:13PM +0100, zithro / Cyril Rébert wrote:
> > Add the shutdown reasons to the paragraph of "xl list" concerning the
> > shutdown status.
> > I have copy/pasted the explanations from the source code :
> >
> >   - tools/xl/xl_info.c (L379)
> Instead of a line number, how about the function name?
>   - tools/xl/xl_info.c (list_domains())
>
> >   - xen/include/public/sched.h (starting L158)
> And here, I think that would be "sched_shutdown_reason".
>
> Line number tend to change as we add more code, which mean that the line
> number is only valid at the time it is written into the patch
> description. But functions and struct name are less likely to be
> renamed.
Agreed, and for all other remarks too, so will send a v2.
(I'll also add Roger's remark about wrapping the long line).

> <snip>