[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/5] xen/domctl, tools: Introduce a new domctl to get guest memory map
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <xin.wang2@xxxxxxx>
- Date: Tue, 12 Mar 2024 11:06:33 +0800
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yr+6X7xSWaUnvmFFO5ZiabKYnnYNP0V6W0IAmustyf0=; b=iz/523KXuauK0OV9hNG32E1xlCtc6CRA05oSHeOC7oPm35JEz1kp2xPfy2G/i+ultvu9PmlMx1iq+2TdN5iRknGwFVtx1S17CwWznAcW9svIGsaP7Y4HfqL066IuSGUeU80oluY+KGIs7570RHywghA50iyV4EuemKnZmbNDDSUl6//L8xNrItrsqktv1kxuLXkpSW552ysc8zwJSlae3n2Y5Zt8WWO+L8TS36NdFo7DSR71VHg0zMajDSGo/ap3pmtsu/yycduy/zq7vQZJ0lMLaQz+xSDPFDTMosYnng4i2tDkEia3w9B34J0TcxUVJL/Eu8G7gUr+bJJX+97q7g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n8BkrzFWZEd0o+tqV5FdVLfeJaMO4SEW1LIe03lanVK+nAt6cV3rsfQZRGLiy7n3VUCModkGLQyFB4T38FFHhh1QL2YrlVMgawbxfNYwcPPwPCeKR1kiXQf87Qwn5iE0y7O0j3pIGTsSiXWI1LQc7p9cCZw9OJ3HBX+TJlZPnBHEfNU3tNSJqrHyQJVLY2dWRtOSxSHjlab3LYxvVhFfpQJe1+qtANRBnmAdEp8Sqion2I3vZ8fl+J85zabde4E2LV6Tyzg5AJDPhI35MJjemLEsC4HhkKnpr2/4Uqdr67ukMG1G/iMj+blG+/K8/eM+Fp1C7batxzpAkRBGWc1gBg==
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, "George Dunlap" <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Alec Kwapis <alec.kwapis@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 12 Mar 2024 03:06:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 3/12/2024 12:58 AM, Jan Beulich wrote:
On 08.03.2024 02:54, Henry Wang wrote:
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -946,6 +946,25 @@ struct xen_domctl_paging_mempool {
uint64_aligned_t size; /* Size in bytes. */
};
+#define XEN_MAX_MEM_REGIONS 1
+
+struct xen_mem_region {
+ uint64_t start;
+ uint64_t size;
uint64_aligned_t?
Yes this makes great sense, thanks for catching it here and ...
+ unsigned int type;
uint32_t and explicit padding (incl checking thereof) please.
...here and ...
+};
+typedef struct xen_mem_region xen_mem_region_t;
+DEFINE_XEN_GUEST_HANDLE(xen_mem_region_t);
+
+struct xen_domctl_mem_map {
+ /* IN & OUT */
+ uint32_t nr_mem_regions;
+ /* OUT */
+ XEN_GUEST_HANDLE(xen_mem_region_t) buffer;
XEN_GUEST_HANDLE_64() and explicit padding (+checking) again please.
...here. I will update the patch accordingly and add the padding +
checking in v3.
Kind regards,
Henry
Jan
|
