[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v3 09/16] xen: address violations of MISRA C:2012 Directive 4.10



Hi Simone,

On 11/03/2024 08:59, Simone Ballarin wrote:
Amend inclusion guards to address violations of
MISRA C:2012 Directive 4.10 ("Precautions shall be taken in order
to prevent the contents of a header file being included more than
once").

Inclusion guards must appear at the beginning of the headers
(comments are permitted anywhere) and the #if directive cannot
be used for other checks.

Mechanical change.

Signed-off-by: Simone Ballarin  <simone.ballarin@xxxxxxxxxxx>
Signed-off-by: Maria Celeste Cesario  <maria.celeste.cesario@xxxxxxxxxxx>

Regarding Jan's comment, I don't have any strong opinion on whether this patch impair readability in this case. So:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.