Re: [XEN PATCH 07/10] xen/efi: efibind: address violations of MISRA C Rule 20.7

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2024-03-18 17:49, Jan Beulich wrote:
> On 18.03.2024 12:53, Nicola Vetrini wrote:
> > MISRA C Rule 20.7 states: "Expressions resulting from the expansion
> > of macro parameters shall be enclosed in parentheses". Therefore, some
> > macro definitions should gain additional parentheses to ensure that 
> > all
> > current and future users will be safe with respect to expansions that
> > can possibly alter the semantics of the passed-in macro parameter.
> >
> > No functional change.
> >
> > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > ---
> > This file is matched by exclude-list.json, but the fix is rather 
> > trivial
> > and impacts code that in under the scope of MISRA compliance.
> On the same basis as the other change:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks.

> I wonder though: Where do we draw the line?
>
> Jan
So far the policy, at least from my side, has been to submit a patch if 
the change is simple enough, to avoid adding a special case that needs 
to be documented and maintained.
In case concerns were raised, propose a deviation and follow up from 
there.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)