Re: [PATCH for-9.1 v5 11/14] memory: Add Error** argument to the global_dirty_log routines

[Fabiano Rosas <farosas@xxxxxxx>]

Cédric Le Goater <clg@xxxxxxxxxx> writes:

> Now that the log_global*() handlers take an Error** parameter and
> return a bool, do the same for memory_global_dirty_log_start() and
> memory_global_dirty_log_stop(). The error is reported in the callers
> for now and it will be propagated in the call stack in the next
> changes.
>
> To be noted a functional change in ram_init_bitmaps(), if the dirty
> pages logger fails to start, there is no need to synchronize the dirty
> pages bitmaps. colo_incoming_start_dirty_log() could be modified in a
> similar way.
>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
> Cc: Paul Durrant <paul@xxxxxxx>
> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: David Hildenbrand <david@xxxxxxxxxx>
> Cc: Hyman Huang <yong.huang@xxxxxxxxxx>
> Signed-off-by: Cédric Le Goater <clg@xxxxxxxxxx>

Reviewed-by: Fabiano Rosas <farosas@xxxxxxx>