Re: [PATCH v6 06/20] xen/bitops: put __ffs() and ffz() into linux compatible header

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2024-03-20 at 16:42 +0100, Jan Beulich wrote:
> On 15.03.2024 19:06, Oleksii Kurochko wrote:
> > --- a/xen/lib/find-next-bit.c
> > +++ b/xen/lib/find-next-bit.c
> > @@ -9,6 +9,7 @@
> >   * 2 of the License, or (at your option) any later version.
> >   */
> >  #include <xen/bitops.h>
> > +#include <xen/linux-compat.h>
> >  
> >  #include <asm/byteorder.h>
> 
> Hmm, no, a library source would better not include this header.
> Surely
> the ffz() can be taken care of locally here?
Considering that ffz() is only used here, then it makes sense to drop
ffz() from xen/linux-compat.h> and defines it here as:
#define ffz(x) ffsl(~(x)) - 1

~ Oleksii