[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/11] xen/arm: List static shared memory regions as /memory nodes
- To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 25 Mar 2024 09:58:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b4H9KjaFfUVYMideOenLmn3bhD7kmltbtFAZOlSa/Co=; b=fI3LVZH/2gJaNH4N6WnhkS2MMZO4vZVlPOcRXZMF2DEsEZ+dcT3K+7P5bRHUa8vwX6iy/qxptgWoJQVCL80aW1dVCaS1Y8QckHspWkBX57moZsUttFYILl/3XmeL0basi78tp/JCzpsYljZ6RoMeiHyPBEe5Hft9XCuZmp38dzkNgRHgA0mQYOxSZCfh+3kEz34VCsqZSiHM/1Znol0w/MDOSQh2g/ARqnVs/zeAbolBF0+tU2UClZbFRLMHbPq4h5PRCM72bPHs3UHWI3rGuEOKq29XvnyhcNtt4YlTzqVh+vHIl9gCq69aXyua9pLr2JauL5OVXd8NIUxWvnNblQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfNgrUG9g+DHdtC0T5DQXbJ3LSeO8pAvFhkgmlLedlxs9NJ9pln+fh3EXkw3FcBSLFRutR+WstNcQqY62ZNFV5pb1OQ9M+04CEFOuwedrHKvsGlMaAtxAuI9nyxVret1dnX057idt4A0gXHrecjw6hnbjRbXwMLlsATsgSN3Y/SNnYBWL57zWo3wJeYPIgYvdBl7cwoLhsWkwqEmbU5vaIC80/uULqMOJ3sTNeYTs61mCWIbsTTvv21pRmH2Shy8pxrrnLygnOJ3Guh66XoiPcdknnrNruhRd4HNZz0izdgTroCKpp0JbChpiWaKR6rb6XOUHFAnKcLbdjTuyRvjZw==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 25 Mar 2024 08:59:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Luca,
On 12/03/2024 14:03, Luca Fancellu wrote:
>
>
> Currently Xen is not exporting the static shared memory regions
> to the device tree as /memory node, this commit is fixing this
> issue.
Looking at the implementation, you will always call make_shm_memory_node()
twice. For the first
time, to create /memory node and for the second time to create entry under
/reserved-memory. Also,
you will create a separate /memory node for every single shmem region instead
of combining them
in a single /memory region like make_memory_node() would do. Can't we reuse
this function for simplicity?
Also, afaict it is not forbidden to specify shmem range (correct me if I'm
wrong), where guest address will be
within with RAM allocated by Xen (e.g. GPA RAM range 0x40000000 - 0x60000000
and shmem is at 0x50000000). In this case,
you would create yet another /memory node that would result in overlap (i.e.
more than one /memory node specifying the same range).
~Michal
|
