Re: [XEN PATCH 07/11] xen/page_alloc: address violations of MISRA C Rule 20.7

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

Hi Jan,

sorry, forgot to reply.

On 2024-03-25 10:27, Jan Beulich wrote:
> On 22.03.2024 17:01, Nicola Vetrini wrote:
> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -150,7 +150,7 @@
> >  #include <asm/paging.h>
> >  #else
> >  #define p2m_pod_offline_or_broken_hit(pg) 0
> Seeing this in context: Does Misra also have a rule demanding 
> evaluation
> of macro arguments?
No such rule. There is one for unused function parameters, though.

> > -#define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL)
> > +#define p2m_pod_offline_or_broken_replace(pg) BUG_ON((pg) != NULL)
> Or easier
>
> #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg)
>
> ?
Good point. I'll modify it.

> Jan
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)