[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] arm: smmu: allow SMMU to have more IRQs than context banks
- To: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 2 Apr 2024 09:28:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N5C4BD1il94gtoJ4MVzbYstUmHjOmvis1l9KSTC2WrI=; b=d+nTBXmqC1pMM/H1Uic5JwA2Qoh5AivGE12Hb6yFaowWwXUcyw9owh8S/TKzNtQgeCcVcWfClo5T09p/wtdFSloZdHVlaZiOV9P2UpFPDtT3hZVFvQ4VowGOJPR0Ou9zp5wM4w7AON9xyu1MiIn9gvVKa6TZpYS4FSpZQbaw+/Z6mb9D2MZxrw6SdoEG4+mN0hUmHI9r2I0muexh5ZLSYkx6WNMzBg9Hiel7L6uy60uJyQMapTJD01DXncJD9lnY7zml6RlY1PTJw6+pUjQP22SsSli+Z4VPoXvBdaD5FuKy2qk5Zulo5Z66vhe9aNXiR2eL8N/IqPJriLngXwkbpQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GcckKd2UCKq1hlK4IBDVwpSci/QtGq+mWwAC6rUHNcc587mvCCCnxRf92GfCmY6SU/jB2h1s9faZ19e4qrnGeAVSQkGYkG/Pz9mF7WUtm4pn+NdxSZAK5ve2YR1XiQgArJr0Z6KbwXZixqu2UlTVaMklCQlekDjp7m664VinHlkm9XPzpAhzI1GgjL7k4iuxx8my8GDGFFYUFpH5NCkYooq1LpW/cI4DNABRWpyV3fgjwyK48qVAJRzUf/sIJUhT7FJF8MG/MdavMpobh/hetR/esJxft9IqGwZBgJWCbgNgjjIvibIABGP9uxszGFCXpmENXls8eFRBmKz0AEGPqw==
- Cc: Julien Grall <julien@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Tue, 02 Apr 2024 07:28:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hello,
On 29/03/2024 01:08, Volodymyr Babchuk wrote:
>
>
> I encountered platform, namely Qualcomm SA8155P where SMMU-compatible
NIT: a commit msg should be written in imperative mood
> IO-MMU advertises more context IQRs than there are context banks. This
> should not be an issue, we need to relax the check in the SMMU driver
> to allow such configuration.
>
> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
> ---
> xen/drivers/passthrough/arm/smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/drivers/passthrough/arm/smmu.c
> b/xen/drivers/passthrough/arm/smmu.c
> index 32e2ff279b..2dd3688f3b 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2550,7 +2550,7 @@ static int arm_smmu_device_dt_probe(struct
> platform_device *pdev)
> parse_driver_options(smmu);
>
> if (smmu->version > ARM_SMMU_V1 &&
> - smmu->num_context_banks != smmu->num_context_irqs) {
> + smmu->num_context_banks > smmu->num_context_irqs) {
This was done in Linux by commit:
d1e20222d537 ("iommu/arm-smmu: Error out only if not enough context interrupts")
However, they also ignore superfluous interrupts. Shouldn't we do the same?
~Michal
|
