[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 1/9] x86/vlapic: tidy switch statement and address MISRA violation



On Mon, 8 Apr 2024, Jan Beulich wrote:
> On 05.04.2024 11:14, Nicola Vetrini wrote:
> > Remove unneded blank lines between switch clauses.
> 
> "Unneeded" based on what? We're carefully trying to improve readability of
> large switch() statements by adding such blank lines (at least) between non-
> fall-through case blocks, and you go and remove them?

To be fair it is almost impossible to figure out the correct coding
style in Xen by looking at existing code and/or CODING_STYLE.

Except for the blank lines, the change itself looks correct to me

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.