Re: [PATCH v2 0/6] xenwatchdogd bugfixes and enhancements

[Anthony PERARD <anthony.perard@xxxxxxxxx>]

On Fri, Mar 29, 2024 at 11:10:50AM +0000, leigh@xxxxxxxxxxxxx wrote:
> From: Leigh Brown <leigh@xxxxxxxxxxxxx>
> 
> The primary intention of this patch series is to replace the 
> pathologically bad behaviour of rebooting the domain if you run 
> "xenwatchdogd -h". To that end, I have implemented comprehensive 
> argument validation. This validation ensures you can't pass 
> arguments that instantly reboot the domain or cause it to spin 
> loop running sleep(0) repeatedly.
> 
> I added a couple of enhancements whilst working on the changes as 
> they were easy enough.  In particular, being able to run in the
> foreground, disarming the watchdog on exit, help and a manpage.
> 
> Changes since v1:
> - Add Signed-off-by on every patch.
> - Make global variables static.
> 
> Full list of changes:
> - Use getopt_long() to add -h/--help with associated usage help.
> - Add -F/--foreground parameter to run without daemonizing.
> - Add -x/--save-exit parameter to disarm the watchdog when exiting.
> - Validate timeout is numeric and is at least two seconds.
> - Validate sleep is numeric and is at least one and less than timeout.
> - Check for too many arguments.
> - Use symbol constants instead of magic numbers where possible.
> - Make all functions except main() and global variables static.
> - Add a manual page for xenwatchdogd().

It might be worth mentioning something about these in the CHANGELOG.
Probably not need to go into detail, maybe just "improved xenwatchdogd
options, see new man page."

Cheers,

-- 
Anthony PERARD