[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v1 4/5] xen/arm: allow dynamically assigned SGI handlers
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 10 Apr 2024 15:24:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYI8i5pzAIr9hWphtaCpet18oeiaiNBVZUBjSOu4Qr8=; b=IJ/rsmg23GxBAq/VNgkLXJ+KJrOJ++IhnLCOw33L+1Mgtz3jbNWXtDA/P5eJ/El8/O+qDgGpXBSnDO+X7xieo2+sExetJLKCVDNHTxDvijN1Acc/bjDgdkeT/+ZG9Ev+/uH6LiJV92alFh739CrMYZLxXObMwv+iwvIrNJCkfD1ILdiEkKXYinpaFkjPebfG8Uqcr+qBZmDj1wVUoBrbgfoHCdQ1KIzLv+oDbQS8uZTBqemXVXkkQTG2Dhv6EBe2Yx5H1UphAAGgDB4H+akQjRApEpwwNPSLoj1pM79kR6uTnMB77K6VhUOl/z4cZNWT2xU7OVQMS42GRSXnl+9y3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVijp9fzNXtFgdzpk89AQ+dU2QBslN7RXWqpEmEmZhNI2lXTVX8/g6UpNxoXTq6QlBQzhZp+9tOU5CSgw4DySvaub8rQj4wCUKjDD/FfoF3HW6lZ0VRkn94T1cZBP2Pkarqep9tFSSlIwEezZWGGvxgJJJLPiC6zHLo6zlzO/TckFz0sk1UHt7gYbHmL7HXnCR+TGB9V2TSx+j+M3nMaBM5YDL32RaayVzuL1XGyp830vUER4WvzxYKECSNkQsPEI6W+vHLzMibv1fEBmvx2W3fKA3oyJmBbVsQpRK/GiYxWhka0L9d2i4CXCa4iiEq4FHypMVHbiUIrr+29p47HYw==
- Cc: <patches@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 10 Apr 2024 13:24:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jens,
On 09/04/2024 17:36, Jens Wiklander wrote:
>
>
> Updates so request_irq() can be used with a dynamically assigned SGI irq
> as input.
At this point it would be handy to mention the use case for which you need to
add this support
>
> gic_route_irq_to_xen() don't gic_set_irq_type() for SGIs since they have
> their type assigned earlier during boot
Could you elaborate more on that? Do you mean that SGIs are always edge
triggered and there's no need
for setting the type?
>
> gic_interrupt() is updated to route the dynamically assigned SGIs to
> do_IRQ() instead of do_sgi(). The latter still handles the statically
> assigned SGI handlers like for instance GIC_SGI_CALL_FUNCTION.
>
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
Other than that, it LGTM:
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
but I would like other maintainers (especially Julien) to cross check it.
~Michal
|
