Re: [PATCH v2 1/4] docs: add xen_ulong_t to the documented integers sizes/alignments

[Julien Grall <julien.grall.oss@xxxxxxxxx>]

On Wed, 10 Apr 2024 at 19:47, Stefano Stabellini <stefano.stabellini@xxxxxxx> wrote:

xen_ulong_t is widely used in public headers.

Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
---

Given that xen_ulong_t is used in public headers there could be a better
place for documenting it but this was the most straightforward to add.
---
 docs/misra/C-language-toolchain.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/docs/misra/C-language-toolchain.rst b/docs/misra/C-language-toolchain.rst
index 5ddfe7bdbe..7a334260e6 100644
--- a/docs/misra/C-language-toolchain.rst
+++ b/docs/misra/C-language-toolchain.rst
@@ -531,6 +531,17 @@ A summary table of data types, sizes and alignment is below:
      - 64 bits
      - x86_64, ARMv8-A AArch64, RV64, PPC64

+   * - xen_ulong_t
+     - 32 bits
+     - 32 bits
+     - x86_32
+
+   * - xen_ulong_t
+     - 64 bits
+     - 64 bits
+     - x86_64, ARMv8-A AArch64, RV64, PPC64, ARMv8-A AArch32, ARMv8-R
+       AArch32, ARMv7-A

We support neither ARMv8-R nor ARMv8-A Aarch32.

I could possibly accept the latter because it works to. But the former is so far misleading.

Cheers,

+
    * - long long
      - 64-bit
      - 32-bit
--
2.25.1