[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] xen/virtual-region: Rework how bugframe linkage works
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 11 Apr 2024 08:20:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KNQBc+WRHN83s8CDV6RHZ6lMWbh9DMwkNyvlj3ivSSw=; b=NkWPyJVkvf3ksvttNIdwcgmg6szidaKLp8rIcZ7qT3+1eZ97upgik/gNHqgM99do0zzEXS4dsMUU7aWz+t7+lGo+Vdt7chjN+kdhkIaqXJ66EP+2uLNQ85c2oDQHGNSvSwWmGPI8QEfUJyxu7yINUT95BVqL1PoKLMkFU8Gd8SlxTanV4HHOERmvaZtJZbfhEMXGHuowXqOYVYJGMChzeXcXDgZfIovjdA3vbV4H4hHYq8bTLiZifLf0u2n/t22slfA8VQXOWFDPHk0KRsoKLhvJeCFBuYYg91FXkUu8Cp5WlD9ByIbTK1/4cfd4mEFXreiBTmYZxakhXjQZq18q+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ccgh9R7ncAKScMZkREoy1fEg+odVb7jSmpUhWji/PLatIYgMWjVyEZsOSKbOT5OVOqn8Dpzni2D8913x/hXakwtLBWeS+XqZ3LZR8PV74asdcegRvnxjMcygc7LSlm1CZyEqsV3TxeTBmXRTDFb+ZWivzRdkAR/06NrAkaNwqZ2p4P3lsIGySRzNziSejMwt4/AeUowU+gAa12a1QdhhfWV7lrdqeA6GWArH8hjbeo/ZZKSY8ro+2oTxqpiENUkLwxRjDQ0RLX23T4dhQ8c8pGHpHA8RCKfzprc45uj+Y2IQ9g//XYru5HP8H92r8vrAR5Zrq65clV1J1pRb0Czp4A==
- Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
- Delivery-date: Thu, 11 Apr 2024 06:20:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Andrew,
On 10/04/2024 20:42, Andrew Cooper wrote:
>
>
> The start/stop1/etc linkage scheme predates struct virtual_region, and as
> setup_virtual_regions() shows, it's awkward to express in the new scheme.
>
> Change the linker to provide explicit start/stop symbols for each bugframe
> type, and change virtual_region to have a stop pointer rather than a count.
>
> This marginly simplifies both do_bug_frame()s and prepare_payload(), but it
NIT: s/marginly/marginally
> massively simplifies setup_virtual_regions() by allowing the compiler to
> initialise the .frame[] array at build time.
>
> virtual_region.c is the only user of the linker symbols, and this is unlikely
> to change given the purpose of struct virtual_region, so move their externs
> out of bug.h
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
For Arm:
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
