Re: [PATCH v4 1/3] xen/arm: Add imx8q{m,x} platform glue

[Kelly Choi <kelly.choi@xxxxxxxxx>]

Hi everyone,

We all have a responsibility and pledge to make this community a welcoming environment.

As such, I would like to request we keep the Code of Conduct and patch discussions separate. 

Should there be a need for any Code of Conduct complaints/investigations, this will be treated separately.  

Thank you John for your contributions. 

Many thanks,

Kelly Choi

Community Manager

Xen Project 

On Mon, Apr 15, 2024 at 12:03 PM Julien Grall <julien@xxxxxxx> wrote:

On 15/04/2024 11:50, Andrew Cooper wrote:
> On 15/04/2024 11:25 am, Julien Grall wrote:
>> Hi John,
>>
>> I saw this patch was committed. I have one question this may require
>> some adjustment.
>>
>> On 08/04/2024 17:11, John Ernberg wrote:
>>> ---
>>>    xen/arch/arm/platforms/Makefile |   1 +
>>>    xen/arch/arm/platforms/imx8qm.c | 139 ++++++++++++++++++++++++++++++++
>>>    2 files changed, 140 insertions(+)
>>>    create mode 100644 xen/arch/arm/platforms/imx8qm.c
>>>
>>> diff --git a/xen/arch/arm/platforms/Makefile
>>> b/xen/arch/arm/platforms/Makefile
>>> index 8632f4115f..bec6e55d1f 100644
>>> --- a/xen/arch/arm/platforms/Makefile
>>> +++ b/xen/arch/arm/platforms/Makefile
>>> @@ -9,5 +9,6 @@ obj-$(CONFIG_ALL_PLAT)   += sunxi.o
>>>    obj-$(CONFIG_ALL64_PLAT) += thunderx.o
>>>    obj-$(CONFIG_ALL64_PLAT) += xgene-storm.o
>>>    obj-$(CONFIG_ALL64_PLAT) += brcm-raspberry-pi.o
>>> +obj-$(CONFIG_ALL64_PLAT) += imx8qm.o
>>>    obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp.o
>>>    obj-$(CONFIG_MPSOC_PLATFORM)  += xilinx-zynqmp-eemi.o
>>> diff --git a/xen/arch/arm/platforms/imx8qm.c
>>> b/xen/arch/arm/platforms/imx8qm.c
>>> new file mode 100644
>>> index 0000000000..3600a073e8
>>> --- /dev/null
>>> +++ b/xen/arch/arm/platforms/imx8qm.c
>>> @@ -0,0 +1,139 @@
>>> +/* SPDX-License-Identifier: GPL-2.0-or-later */
>>
>> The majority of Xen code is using GPL-2.0-only. In the early days for
>> Xen on Arm we started to use GPLv2+ which I consider it was a mistake.
>> Unfortunately this started to spread as people copied/pasted the same
>> copyright headers.
>>
>> So can you confirm whether you intended to use GPL-2.0+? If not would
>> you be able to send a patch to adjust it? (Better to it before there
>> are more modifications).
>
> Julien: I've called you out multiple times before.

And there are multiple thread explaining why I am requesting if we can
use GPLv2-only. In fact from CONTRIBUTING:

The recommended license of a directory will depend on the COPYING file.
If the new file is using a different license, this should be highlighted
and discussed in the commit message or cover letter introducing the
file.

> Don't ever bully contributors into changing licensing.  It is
> unacceptable behaviour, and in most cases - including this one by the
> looks of things - not legal.

I don't think I have bullied the contributor. I have asked politely
whether it can be done. There is nothing illegal (see above).

The problematic behavior is you trying to pressure the other people to
accept your point of view by been condescending or insulting them like
you did here.

I have reported this behavior several times to CoC. And I guess this
need to happen again.

Cheers,

--
Julien Grall