[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] public: xen: Define missing guest handle for int32_t


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 17 Apr 2024 14:14:42 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=87AOnwj0YmJESyxXcN9JBbPhqtf3pO0sLJy1fuUzuxk=; b=M2AVjA7JXXbinoIa99XVnmXMr92iz1OMguDKyPKVT1ZFj5oAvQUyQxatOJ3oOu+hfyf+ZqBfsXLtHMSJ4cIm6qN2G5R6prUoK7BdJlzpywq/iOm28CLysXc5iih1d6Lt3uAjxhlMhCTqJrZV+v7MCVwNxJZ0nNw4Cm4GI4YV1w4TJCFyIu1iRzjQoyj24Z6x3Sr8BL+9Fl2toiSxdRZy8rTD1cNKeWcmK+XA/nKqmSvWRK4o8/GzLGxuUbiUFOZuWS2dkgV/KhhvsGd+PE3g6cC6lGyOvUPMcpEAlTpHWTopBdsKyRrkhErjXfkr4vaZCGKYf5DbefW8suXRdInCuA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHYwIlxrc2XzNNv2z1yfQMxSDRNoilAUyMlT4Xl+iXUbCOdgrV+pCdKb6lrx2XNKAT9TIPD1CFCCKWEucT6MjOsWa3b23LKSuxv+ev2k6IgnkmVL8HAy49r8BfuL1pVwZwFtVgpHOwcQDiB92E2NfizwE1mmp2CbpwECte7JUN313lwWy15tU29TNhoGJvnG074nwI0NkizzmXMnWsPUJi0IpoZAtQIofuqo59Yky1v6etlq+sKm3FeYtG/XkZ0IXcZm+xbPIaxB+HPp3pA7ujTHCu41qZI12RkB868cpxqmjKBB9v2o3gvwK0100p8F2mNNzCno7rhlnYzC8UnVBQ==
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 17 Apr 2024 12:14:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t
in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined
for it. This results in a build failure. Example on Arm:

./include/public/arch-arm.h:205:41: error: unknown type name 
‘__guest_handle_64_int32_t’
  205 | #define __XEN_GUEST_HANDLE(name)        __guest_handle_64_ ## name
      |                                         ^~~~~~~~~~~~~~~~~~
./include/public/arch-arm.h:206:41: note: in expansion of macro 
‘__XEN_GUEST_HANDLE’
  206 | #define XEN_GUEST_HANDLE(name)          __XEN_GUEST_HANDLE(name)
      |                                         ^~~~~~~~~~~~~~~~~~
./include/public/memory.h:277:5: note: in expansion of macro ‘XEN_GUEST_HANDLE’
  277 |     XEN_GUEST_HANDLE(int32_t) errs;

Fix it. Also, drop guest handle definition for int given no further use.

Fixes: afab29d0882f ("public: s/int/int32_t")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
 xen/include/public/xen.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
index b47d48d0e2d6..8fd0cec880d5 100644
--- a/xen/include/public/xen.h
+++ b/xen/include/public/xen.h
@@ -28,7 +28,6 @@
 /* Guest handles for primitive C types. */
 DEFINE_XEN_GUEST_HANDLE(char);
 __DEFINE_XEN_GUEST_HANDLE(uchar, unsigned char);
-DEFINE_XEN_GUEST_HANDLE(int);
 __DEFINE_XEN_GUEST_HANDLE(uint,  unsigned int);
 #if __XEN_INTERFACE_VERSION__ < 0x00040300
 DEFINE_XEN_GUEST_HANDLE(long);
@@ -36,6 +35,7 @@ __DEFINE_XEN_GUEST_HANDLE(ulong, unsigned long);
 #endif
 DEFINE_XEN_GUEST_HANDLE(void);
 
+DEFINE_XEN_GUEST_HANDLE(int32_t);
 DEFINE_XEN_GUEST_HANDLE(uint64_t);
 DEFINE_XEN_GUEST_HANDLE(xen_pfn_t);
 DEFINE_XEN_GUEST_HANDLE(xen_ulong_t);
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.