Xen project Mailing List

Re: [PATCH 2/4] xen/xlat: Sort structs per file

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Date: Thu, 18 Apr 2024 11:00:17 +0200

Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL

Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>

Delivery-date: Thu, 18 Apr 2024 09:00:34 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.04.2024 17:41, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> While I don't mind the change as is, "sort" is ambiguous here in one regard. Personally I'd prefer if those parts of the change were dropped, but I can live with the sorting criteria being spelled out in the description: > @@ -40,13 +40,6 @@ > > ? cpu_offline_action arch-x86/xen-mca.h > ? mc arch-x86/xen-mca.h > -? mcinfo_bank arch-x86/xen-mca.h > -? mcinfo_common arch-x86/xen-mca.h > -? mcinfo_extended arch-x86/xen-mca.h > -? mcinfo_global arch-x86/xen-mca.h > -? mcinfo_logical_cpu arch-x86/xen-mca.h > -? mcinfo_msr arch-x86/xen-mca.h > -? mcinfo_recovery arch-x86/xen-mca.h > ! mc_fetch arch-x86/xen-mca.h > ? mc_info arch-x86/xen-mca.h > ? mc_inject_v2 arch-x86/xen-mca.h > @@ -54,6 +47,13 @@ > ? mc_msrinject arch-x86/xen-mca.h > ? mc_notifydomain arch-x86/xen-mca.h > ! mc_physcpuinfo arch-x86/xen-mca.h > +? mcinfo_bank arch-x86/xen-mca.h > +? mcinfo_common arch-x86/xen-mca.h > +? mcinfo_extended arch-x86/xen-mca.h > +? mcinfo_global arch-x86/xen-mca.h > +? mcinfo_logical_cpu arch-x86/xen-mca.h > +? mcinfo_msr arch-x86/xen-mca.h > +? mcinfo_recovery arch-x86/xen-mca.h > ? page_offline_action arch-x86/xen-mca.h Imo this sorting was fine (at least one further instance below): Whether underscore sorts ahead of lower case letters depends on how sorting is done. I take you assume sorting as per the C locale, when the original sorting was considering undercores to be separators, i.e. in a different character class (together with e.g. dash or tilde). When using C local sorting, I think arch-x86/xen-@arch@.h also would need moving past arch-x86/xen.h (whereas right now all separators are deemed equal and hence @ comes ahead of h which in turn is ahead of m). Jan

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.