Re: [PATCH v8 01/17] xen/riscv: disable unnecessary configs

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Thu, 2024-04-18 at 09:14 +0200, Jan Beulich wrote:
> On 17.04.2024 12:04, Oleksii Kurochko wrote:
> > --- a/automation/gitlab-ci/build.yaml
> > +++ b/automation/gitlab-ci/build.yaml
> > @@ -515,10 +515,14 @@ alpine-3.18-gcc-debug-arm64-boot-cpupools:
> >  .riscv-fixed-randconfig:
> >    variables: &riscv-fixed-randconfig
> >      EXTRA_FIXED_RANDCONFIG: |
> > +      CONFIG_BOOT_TIME_CPUPOOLS=n
> >        CONFIG_COVERAGE=n
> >        CONFIG_EXPERT=y
> >        CONFIG_GRANT_TABLE=n
> >        CONFIG_MEM_ACCESS=n
> > +      CONFIG_PERF_COUNTERS=n
> > +      CONFIG_LIVEPATCH=n
> > +      CONFIG_XSM=n
> 
> While XSM and BOOT_TIME_CPUPOOLS are covered in the description, I
> struggle
> with PERF_COUNTERS: What's missing there (besides trivial asm/perfc.h
> and
> asm/perfc_defn.h)?
I think only them are needed. I can wrap them by #ifdef
CONFIG_PERF_COUNTERS to check.

We could wrap asm/perfc.h by #ifdef CONFIG_PERF_COUNTERS, but it seems
it should be a separate patch and until there is no such patch it
should be disabled.


>  As to LIVEPATCH: I suppose there ought to be HAS_LIVEPATCH
> allowing arch-es to indicate whether they support that.
Hmm, I haven't seen HAS_LIVEPATCH. I think the intention was that it is
enough to have a default value, but it can be overridden.
   config LIVEPATCH
        bool "Live patching support"
        default X86
   ....
   
~ Oleksii