Re: [PATCH v2 3/3] tools/golang: Run `go vet` as part of the build process

[Nick Rosbrook <rosbrookn@xxxxxxxxx>]

On Fri, Apr 19, 2024 at 10:00 AM George Dunlap <george.dunlap@xxxxxxxxx> wrote:
>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxx>
> ---
> CC: Nick Rosbrook <rosbrookn@xxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>  tools/golang/xenlight/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile
> index c5bb6b94a8..645e7b3a82 100644
> --- a/tools/golang/xenlight/Makefile
> +++ b/tools/golang/xenlight/Makefile
> @@ -29,6 +29,7 @@ $(subst .gen.,.%.,$(GOXL_GEN_FILES)): gengotypes.py 
> $(LIBXL_SRC_DIR)/libxl_types
>  # so that it can find the actual library.
>  .PHONY: build
>  build: xenlight.go $(GOXL_GEN_FILES)
> +       CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) 
> $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) 
> $(APPEND_LDFLAGS)" $(GO) vet
>         CGO_CFLAGS="$(CFLAGS_libxenlight) $(CFLAGS_libxentoollog) 
> $(APPEND_CFLAGS)" CGO_LDFLAGS="$(call xenlibs-ldflags,light toollog) 
> $(APPEND_LDFLAGS)" $(GO) build -x
>
>  .PHONY: install
> --
> 2.25.1
>
Acked-by: Nick Rosbrook <rosbrookn@xxxxxxxxx>

Thanks,
Nick