Re: [PATCH v3 2/4] tools/misc: xenwatchdogd enhancements

[Anthony PERARD <anthony.perard@xxxxxxxxx>]

On Thu, Apr 11, 2024 at 07:20:21PM +0100, leigh@xxxxxxxxxxxxx wrote:
> From: Leigh Brown <leigh@xxxxxxxxxxxxx>
> 
> Add usage() function, the ability to run in the foreground, and
> the ability to disarm the watchdog timer when exiting.
> 
> Add enhanced parameter parsing and validation, making use of
> getopt_long().  Check the number of parameters are correct, the
> timeout is at least two seconds (to allow a minimum sleep time of
> one second), and that the sleep time is at least one and less
> than the watchdog timeout.
> 
> With these changes, the daemon will no longer instantly reboot
> the domain if you enter a zero timeout (or non-numeric parameter),
> and prevent the daemon consuming 100% of a CPU due to zero sleep
> time.
> 
> Signed-off-by: Leigh Brown <leigh@xxxxxxxxxxxxx>

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD