Re: [PATCH 11/15] tools/helpers: Add get_overlay

[Henry Wang <xin.wang2@xxxxxxx>]

Hi Stewart,

On 4/26/2024 9:45 AM, Stewart Hildebrand wrote:
> On 4/24/24 20:43, Henry Wang wrote:
> > Hi Jan,
> >
> > On 4/24/2024 2:08 PM, Jan Beulich wrote:
> > > On 24.04.2024 05:34, Henry Wang wrote:
> > > > From: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
> > > >
> > > > This user level application copies the overlay dtbo shared by dom0 while doing
> > > > overlay node assignment operation. It uses xenstore to communicate with dom0.
> > > > More information on the protocol is writtien in docs/misc/overlay.txt file.
> > > >
> > > > Signed-off-by: Vikram Garhwal <fnu.vikram@xxxxxxxxxx>
> > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
> > > > Signed-off-by: Henry Wang <xin.wang2@xxxxxxx>
> > > > ---
> > > >    tools/helpers/Makefile      |   8 +
> > > >    tools/helpers/get_overlay.c | 393 ++++++++++++++++++++++++++++++++++++
> > > >    2 files changed, 401 insertions(+)
> > > >    create mode 100644 tools/helpers/get_overlay.c
> > > As mentioned before on various occasions - new files preferably use dashes as
> > > separators in preference to underscores. You not doing so is particularly
> > > puzzling seeing ...
> > >
> > > > --- a/tools/helpers/Makefile
> > > > +++ b/tools/helpers/Makefile
> > > > @@ -12,6 +12,7 @@ TARGETS += init-xenstore-domain
> > > >    endif
> > > >    ifeq ($(CONFIG_ARM),y)
> > > >    TARGETS += init-dom0less
> > > > +TARGETS += get_overlay
> > > ... patch context here (demonstrating a whopping 3 dashes used in similar
> > > cases).
> > I am not very sure why Vikram used "_" in the original patch. However I agree you are 
> > correct. Since I am currently doing the follow up of this series, I will use "-" in v2 as 
> > suggested. Thanks.
> Please also add tools/helpers/get-overlay to .gitignore
Thanks for the reminder! Yes sure I will add it.

Kind regards,
Henry