[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [XEN PATCH 4/6] x86emul: address violations of MISRA C Rule 20.7
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx> --- These local helpers could in principle be deviated, but the readability and functionality are essentially unchanged by complying with the rule, so I decided to modify the macro definition as the preferred option. --- xen/arch/x86/x86_emulate/x86_emulate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c b/xen/arch/x86/x86_emulate/x86_emulate.c index 2d5c1de8ecc2..9352d341346a 100644 --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -2255,7 +2255,7 @@ x86_emulate( switch ( modrm_reg & 7 ) { #define GRP2(name, ext) \ - case ext: \ + case (ext): \ if ( ops->rmw && dst.type == OP_MEM ) \ state->rmw = rmw_##name; \ else \ @@ -8611,7 +8611,7 @@ int x86_emul_rmw( unsigned long dummy; #define XADD(sz, cst, mod) \ - case sz: \ + case (sz): \ asm ( "" \ COND_LOCK(xadd) " %"#mod"[reg], %[mem]; " \ _POST_EFLAGS("[efl]", "[msk]", "[tmp]") \ -- 2.34.1
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |