[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[XEN PATCH] common/sched: address a violation of MISRA C Rule 8.8
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: <victorm.lira@xxxxxxx>
- Date: Thu, 20 Jun 2024 17:20:30 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vpxELYzvYWyx31e2HQRfcOug61WECZXw5QfrjJ9qZVA=; b=K/ZN8uNo8mbmbq2oEMx6OL1sY9GyNEQFcbpVGMt4YqIdPVFgln4EdQtUBOyQaQw3NNu1tkSf1hQfpElPwzWhxXnhdlz+hIBHm4X/sePZ8NbP/DrORflbehYUom1XgfgeHs6HOQsHdda/hAqHDELUlbAa4Z0C+wyCONqbsyl0j7SymlE7JxEPzYBv0JXaiqi1m8uvXA23aCFrat01hLwUtzQepUe2P+8K5ekp1w9UtPKN7DrOu3GDRctOQj09VXK8D5/6zJlogm/xbPl8FnHTnNF3ebqGlcmToeWTC94/9v+1m3ZUyBByfR5ASKC01wDpP1qtC2JIIuUelRlHer49xQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zk61pXsG9FqDEl5FulA1Vz3elwRIHugBhKHZ+6umFwl3ZvlMgVC94DnC7+IDQygWF2aZ9dB/7+cFzhXk70b8wYFvsWtiwX9UCYb01CbxQ/+bk1E+seftq3Kwgx9lLwMZfloR+SiwnhCHf5yNq6i0vAtC5PA6126i9gh0WbRGOHkImYNTljgdykV2cBNkWghUi9SCmPgahg01UfIqSWRTLWCSN3vE9nPERx7K5v/O7fGM7i2uyGFMhFGe6P69Tj6fiUVviDhAaYOak396BOKUzqXqoxXAn568mshq1NCtl0zHI7Io8wztlYXrE1qdNaG3f6X/qhlW3pjPDMrhjdxgQw==
- Cc: <sstabellini@xxxxxxxxxx>, Victor Lira <victorm.lira@xxxxxxx>, "Stewart Hildebrand" <stewart.hildebrand@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, "Juergen Gross" <jgross@xxxxxxxx>
- Delivery-date: Fri, 21 Jun 2024 00:21:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Victor Lira <victorm.lira@xxxxxxx>
Rule 8.8: "The static storage class specifier shall be used in all
declarations of objects and functions that have internal linkage"
This patch fixes this by adding the static specifier.
No functional changes.
Reported-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
Signed-off-by: Victor Lira <victorm.lira@xxxxxxx>
---
Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
Cc: Dario Faggioli <dfaggioli@xxxxxxxx>
Cc: Juergen Gross <jgross@xxxxxxxx>
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
---
xen/common/sched/credit2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c
index 685929c290..10a32bd160 100644
--- a/xen/common/sched/credit2.c
+++ b/xen/common/sched/credit2.c
@@ -1476,7 +1476,7 @@ static inline void runq_remove(struct csched2_unit *svc)
list_del_init(&svc->runq_elem);
}
-void burn_credits(struct csched2_runqueue_data *rqd, struct csched2_unit *svc,
+static void burn_credits(struct csched2_runqueue_data *rqd, struct
csched2_unit *svc,
s_time_t now);
static inline void
@@ -1855,7 +1855,7 @@ static void reset_credit(int cpu, s_time_t now, struct
csched2_unit *snext)
/* No need to resort runqueue, as everyone's order should be the same. */
}
-void burn_credits(struct csched2_runqueue_data *rqd,
+static void burn_credits(struct csched2_runqueue_data *rqd,
struct csched2_unit *svc, s_time_t now)
{
s_time_t delta;
--
2.37.6
|