Re: [PATCH for-4.19] xen/arm: static-shmem: request host address to be specified for 1:1 domains

[Julien Grall <julien@xxxxxxx>]

Hi Michal,

On 21/06/2024 10:22, Michal Orzel wrote:
> As a follow up to commit cb1ddafdc573 ("xen/arm/static-shmem: Static-shmem
> should be direct-mapped for direct-mapped domains") add a check to
> request that both host and guest physical address must be supplied for
> direct mapped domains. Otherwise return an error to prevent unwanted
> behavior.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
I would argue that it should be have a fixes tag:

Fixes: 988f1c7e1f40 ("xen/arm: static-shmem: fix "gbase/pbase used 
uninitialized" build failure")
Mainly because while you fixed the build, it was missing the check in 
the "else" part.
I am happy to update it on commit if you are ok with the change.

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall