[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/6] ARM/vgic: Use for_each_set_bit() in vgic_set_irqs_pending()


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Mon, 1 Jul 2024 09:23:05 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=08HJ77tSgDOBOa1xuE2ClWZn+GiCr8E/WjS3yuoIMEc=; b=MN4R8WqVXMB1hXKQsd1YB0sPeaUmb/FB9ZYu8Q5IGTXjzhtktr6zvGvmgz0bmGyEVnZkvSIrNRpdJJihgD9GJAk8ng0HqWAre3a4osJfz+fLcVE3KUjUlJwxKLmclioWc0WuLq3rdT2GxsIXF8xHaH+Z8kuJJ44imM24YTfAjtx+k+zulc0jDjQzLMJtvUIPZYjADfot5QWtagq82BaOWDllKUUZhe6vgwyyLDn1IBZm1dt+TM54evZdA3uCeR3W+VDanOsJ9RCRCPjhnKHVX1TEw77pUJrbPA3LMQ2a3S77JiLGktJl6AQipr5jE6pqfqMkmap8QZEVzXXYLQs2pg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iG0txPOfVT2yfB5sxU5X562irZmKR1Z/yy9Ptf1a2XRCbJ3DH11+8x/6jnRoXzG1/knIbp7cGLxaC7+rkuI3SvP2lksboTS3P/VwPKhHDR9LyUwHhlH6rm+YPVgKoLa1RBOpwApfutkr7h/BXNEy8DRg4kbeN6sME/aYCrrsrVcL1tY925H93ivkDV+vIuW6BD+PKlmvV+byLsY56V+5dGAMVvj5FvAqf1Da+xV50JR3eo99V33lCrHDRo7qEKohyiQHyt4aP4/8RzdBHvbOApqqT4Xzst34d9S+pBQgFL7JnyYbEnwN7SukNJhEzphSPAncoHEfsKpfDzwvGWr3EQ==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>
  • Delivery-date: Mon, 01 Jul 2024 07:23:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 25/06/2024 21:07, Andrew Cooper wrote:
> 
> 
> ... which is better optimised for scalar values, rather than using the
> arbitrary-sized bitmap helpers.
> 
> For ARM32:
> 
>   add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-16 (-16)
>   Function                                     old     new   delta
>   vgic_set_irqs_pending                        284     268     -16
> 
> including removing calls to _find_{first,next}_bit_le(), and two stack-spilled
> words too.
> 
> For ARM64:
> 
>   add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-40 (-40)
>   Function                                     old     new   delta
>   vgic_set_irqs_pending                        268     228     -40
> 
> including removing three calls to find_next_bit().
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.