Re: [XEN PATCH v2 1/2] x86/cpufreq: move ACPI cpufreq driver into separate file

[Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>]

03.07.24 18:07, Jan Beulich:
> On 01.07.2024 14:03, Sergiy Kibrik wrote:
> > Separate ACPI driver from generic initialization cpufreq code.
> > This way acpi-cpufreq can become optional in the future and be disabled
> > from non-Intel builds.
> >
> > Other than acpi_register_driver() helper added and clean up a list of
> > included headers no changes to code were introduced.
> And perhaps that's okay despite the many style violations that you move
> around. However, acpi_register_driver() is too generic a name. How
> about acpi_cpufreq_register() (not not have it grow overly long)? Plus
yes, sure

> > --- /dev/null
> > +++ b/xen/arch/x86/acpi/cpufreq/acpi.c
> > @@ -0,0 +1,622 @@
> > +/*
> > + *  cpufreq.c - ACPI Processor P-States Driver ($Revision: 1.4 $)
> > + *
> > + *  Copyright (C) 2001, 2002 Andy Grover <andrew.grover@xxxxxxxxx>
> > + *  Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@xxxxxxxxx>
> > + *  Copyright (C) 2002 - 2004 Dominik Brodowski <linux@xxxxxxxx>
> > + *  Copyright (C) 2006        Denis Sadykov <denis.m.sadykov@xxxxxxxxx>
> > + *
> > + *  Feb 2008 - Liu Jinsong <jinsong.liu@xxxxxxxxx>
> > + *      porting acpi-cpufreq.c from Linux 2.6.23 to Xen hypervisor
> > + *
> > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > + *
> > + *  This program is free software; you can redistribute it and/or modify
> > + *  it under the terms of the GNU General Public License as published by
> > + *  the Free Software Foundation; either version 2 of the License, or (at
> > + *  your option) any later version.
> > + *
[..]
> > + *
> > + * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > + */
> ... I expect this should be transformed into an SPDX line. I expect the
> one in cpufreq.c wasn't picked up when the conversion was done because
> it doesn't fully match whatever pattern was looked for at the time.
would the line

/* SPDX-License-Identifier: GPL-2.0-or-later */

be correct here?

  -Sergiy