Re: [PATCH RFC] Arm64: amend "xen/arm64: head: Add missing code symbol annotations"

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 10/06/2024 14:37, Jan Beulich wrote:
> While the change[1] didn't go in yet, there is the intention for the ELF
> metadata annotations from xen/linkage.h to also effect honoring of
> CONFIG_CC_SPLIT_SECTIONS. In code that's placement / ordering sensitive,
> these annotations therefore need using with some care.
Looking at the code, I think the ordering only really matter for 
'start'. The rest can be ordered in any way within the assembly file. So...
> [1] https://lists.xen.org/archives/html/xen-devel/2024-02/msg00470.html
>
> Fixes: fba250ae604e ("xen/arm64: head: Add missing code symbol annotations")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> An alternative would be to use LABEL{,_LOCAL}() instead of FUNC{,_LOCAL}().
> That would avoid the need for any override, but would also lose the type
> information. 
... I would suggest to only convert FUNC(start) to LABEL(start).

> Question is whether the annotated ranges really are
> "functions" in whichever wide or narrow sense.
Everything but 'start' are functions.

Cheers,

--
Julien Grall