[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] Add scripts/oss-fuzz/build.sh


  • To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
  • From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
  • Date: Fri, 19 Jul 2024 12:08:53 -0400
  • Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=tklengyel.com; spf=pass smtp.mailfrom=tamas@xxxxxxxxxxxxx; dmarc=pass header.from=<tamas@xxxxxxxxxxxxx>
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1721405371; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=gwqbqtHCZgoj8RT1GA/9N7f8kzTOeXXpyebls8KObrU=; b=F13HKnedmMwbQH2IyrpO7hHme4Q32PJqR0RD0NHRgZN71yfhoBy3OYZsvF8nFy6RdHd2UdUg8Htj0g3Pd5DmtJLFv+L2dad/gBcT66+Xm3znGYwbB4MnzJTxeulpAImZ2+p8RO9mIbTS98ww4cbPuQeBnnxpWUfT80rHD21ASjU=
  • Arc-seal: i=1; a=rsa-sha256; t=1721405371; cv=none; d=zohomail.com; s=zohoarc; b=D4F0XK7cdd/mv0z53PeFdezJVscDVugoTxyfIaOMyc0dGn6n2WWr6y/xombgNLS6bXK/Ai5retY25sjczetP0u9no6BQFMdsoLts5ZbUjhiKh2ZM8qy/kvcTGIYnBv2f/Vb5rHJXD3TvWkQ4hBGBLnbHJF2DgEAr+D7zXaw4X7I=
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Fri, 19 Jul 2024 16:09:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Jul 18, 2024 at 1:36 PM Alejandro Vallejo
<alejandro.vallejo@xxxxxxxxx> wrote:
>
> On Tue Jun 25, 2024 at 11:47 PM BST, Tamas K Lengyel wrote:
> > The build integration script for oss-fuzz targets. Future fuzzing targets 
> > can
> > be added to this script and those targets will be automatically picked up by
> > oss-fuzz without having to open separate PRs on the oss-fuzz repo.
> >
> > Signed-off-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> > ---
> >  scripts/oss-fuzz/build.sh | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >  create mode 100755 scripts/oss-fuzz/build.sh
> >
> > diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh
> > new file mode 100755
> > index 0000000000..2cfd72adf1
> > --- /dev/null
> > +++ b/scripts/oss-fuzz/build.sh
> > @@ -0,0 +1,23 @@
> > +#!/bin/bash -eu
>
> The shebang probably wants to be "/usr/bin/env bash" to account for systems
> that don't have bash specifically there.
>
> With that "-eu" would need to move down a line to be "set -eu"

Thanks but this script is specifically made for just one environment
and does not need to account for other systems.

Cheers,
Tamas



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.