[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] tools/libxs: Rationalise the definition of struct xs_handle
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jason Andryuk <jason.andryuk@xxxxxxx>
- Date: Tue, 23 Jul 2024 09:19:20 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YZOauvET1w9e7dNi8vg7Bmdrxj+nalFrRhfrFnkc3tM=; b=yEDyOs9ioy/kb22Hb1L1+QfmxtvxruRHIOpMWM+0TYyojmymdsea9MVASJeHwbYP0HKb2tWQdrkQFhs0rBVpUqMb1M/9WCLBAxflEOmrWy9UaDlUxy843xKIY/fxNOHlq3bQWt2iPlOjSlBe4T+Ll36AeApkT33DbDoi3xKCQk+kLfmC7dT+rmhv+3P13wKShpNyvYfVHZT3PIVKyp2gtq1qWUzmPjEsqyby2hlOQ/HmgBLHJKoQu/v2DPVBPMTsdgHCafs0HVsVZH0RWzfPDpgbunUvGar7nwTnuSwLcWGSDL6ldZXbwzIJfj7bOK4NOTyYF1vdDtF9WEl/nGtjzQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q94Z90PHb9gmPJcmkyJAfnOOMBHh4eyoudGpVOT2kyE5nXVHt5GBruiJnuZn0vkHE1djQVNArfNI9NQyLPWF2uz2XvnHaxUptU+BNFwhaleGgGhiQoRI+Y3Igpdfr7uP3EFAWUzZ8XUIvrXq+Pmq2valPOBus04uiL6unXlatMR6yGCn8VwAmsIv7eAkb0Tcs+bg42S5/Bz7T49sVEdLuQDH3k/qjZ5P/7NR5otKbft7RXdcbzVb3R73ilDddIIn9uUtNOdb43Xoi8VMxpLmnUSV9nXOH4b0UdORi09K4miTT6TZKFolVGy1/09w4fmDZaPPLKxULv/mvyx6gxsVAw==
- Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 23 Jul 2024 13:42:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024-07-18 12:48, Andrew Cooper wrote:
Right now there are two completely different struct xs_handle definitions,
depend on #ifdef USE_PTHREAD. One is especially well hidden, and often
escapes updates.
Rework struct xs_handle using some interior ifdefary. It's slightly longer,
but much easier to follow. Importanly, this makes it much harder to forget
the !PTHREAD case when adding a "common" variable.
No functional change.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>
|
