Re: [PATCH for-4.19] hotplug: Restore block-tap phy compatibility (again)

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jul 23, 2024 at 07:31:58PM +0200, oleksii.kurochko@xxxxxxxxx wrote:
> On Tue, 2024-07-23 at 11:04 -0400, Jason Andryuk wrote:
> > Oleksii, this is a fix (for an incomplete fix) for 4.19.  76a484193d
> > broke compatibility for block-tap with the blktap2 kernel model (when
> > adding support for tapback).  This finishes restoring blktap2
> > support.
> >
> > I realize it's late in the release if you don't want to take it.
> It's pretty late but I just wanted to clarify:
> 1. Is so critical that we should have this in 4.19?

I don't think it's critical enough to justify delaying the release.
blktap2 is I think an out-of-tree kernel module so probably not very
used.
We might want to at least put a note in "known issue" about blktap2
support by the "block-tap" script been broken.

> 2. If we won't take it now, then will it be backported anyway?

Yes, we want to backport that as soon as 4.19 tree is open for
backports, to have the fix in 4.19.1.

Cheers,

--

Anthony Perard | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech